This repository was archived by the owner on Jun 16, 2025. It is now read-only.
Update formatters with changes from OTP 26 #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbrujohalcon
changed the title
elbrujohalcon
force-pushed
the
elbrujohalcon.otp_formatter.update
branch
from
dfe05fb to
80dd875
Compare
elbrujohalcon
commented
Oct 24, 2024
| inline_clause_bodies => true, | ||
| paper => 50, | ||
| sub_indent => 8}. | ||
| -format #{break_indent => 1}. |
Collaborator
Author
There was a problem hiding this comment.
This and other similar changes are due to a subtle bug (fixed in OTP26's erl_syntax) that reordered map items when they were found in attributes. I decided to just put the items in the order in which erl_syntax returns them (thus, hiding the bug in OTP25) so that tests run seamlessly in 25 and 26.
elbrujohalcon
changed the title
Collaborator
Author
|
My original goal was to move us all the way to OTP27… Look a this module… -module(otp27).
-moduledoc """
New stuff introduced in OTP27.
""".
-export([single_line/0, attributes/0, external/0, markdown/0, false/0, sigils/0]).
-doc "Documentation in one line".
single_line() -> ok.
-doc "You can use".
-doc #{attributes => #{as => maps}}.
attributes() -> {as, maps}.
-doc {file, "external.md"}.
external() -> {in, a, file}.
-doc """
Can contain markdown...
# Title
## Subtitle
### Level 3
**bold**, _italic_
""".
markdown() -> ok.
-doc false.
false() -> false.
sigils() ->
{
~"This is valid now",
~B[<<"This, too">>],
~b"This one, as well",
~"""
This is a multi-line
string that can have a quotation mark: "
as the one in the previous row
""",
~s|Confusingly enough, this is also a string|,
'not a string,'
}.This is how -module(otp27).
-moduledoc(" New stuff introduced in OTP27.").
-export([single_line/0,
attributes/0,
external/0,
markdown/0,
false/0,
sigils/0]).
-doc("Documentation in one line").
single_line() -> ok.
-doc("You can use").
-doc(#{attributes => #{as => maps}}).
attributes() -> {as, maps}.
-doc({file, "external.md"}).
external() -> {in, a, file}.
-doc("Can contain markdown...\n# Title\n## "
"Subtitle\n### Level 3\n**bold**, _italic_").
markdown() -> ok.
-doc(false).
false() -> false.
sigils() ->
{<<"This is valid now"/utf8>>,
<<"<<\"This, too\">>"/utf8>>,
<<"This one, as well"/utf8>>,
<<"This is a multi-line\n string "
"that can have a quotation mark: \"\nas "
"the one in the previous row"/utf8>>,
"Confusingly enough, this is also a string",
'not a string,'}.And this is how -module(otp27).
-moduledoc " New stuff introduced in OTP27.".
-export([single_line/0, attributes/0, external/0, markdown/0, false/0, sigils/0]).
-doc "Documentation in one line".
single_line() ->
ok.
-doc "You can use".
-doc #{attributes => #{as => maps}}.
attributes() ->
{as, maps}.
-doc {file, "external.md"}.
external() ->
{in, a, file}.
-doc "Can contain markdown...\n# Title\n## Subtitle\n### Level 3\n**bold**, _italic_".
markdown() ->
ok.
-doc false.
false() ->
false.
sigils() ->
{<<"This is valid now"/utf8>>,
<<"<<\"This, too\">>"/utf8>>,
<<"This one, as well"/utf8>>,
<<"""
This is a multi-line
string that can have a quotation mark: "
as the one in the previous row
"""/utf8>>,
"Confusingly enough, this is also a string",
'not a string,'}.That's because the parsers do not return information about…
|
pablocostass
approved these changes
Oct 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intention of this PR was upgrading only the
otp_formatterto work with OTP 26 and 27 so a future PR could update the other formatters. But I quickly realized that, in order to run tests with newer versions of OTP, I needed to update all the formatters.So… missing tasks:
lib/syntax_tools/test/syntax_tools_SUITE_data/between versions.